I can only create one spatial Bookmark in current master

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)
Original Redmine Issue: 17539
Affected QGIS version: master
Redmine category:gui
Assignee: Alessandro Pasotti

---

Creating a new project, and for example add some wms layers like:

qgis.utils.iface.addRasterLayer(
"tileMatrixSet=EPSG:28992&crs=EPSG:28992&layers=brtachtergrondkaart&styles=&format=image/png&url=http://geodata.nationaalgeoregister.nl/tiles/service/wmts/brtachtergrondkaart", # uri
"wmts master example", # name for layer (as seen in QGIS)
"wms" # dataprovider key
)

zooming in and create a bookmark (and not adding a name), I cannot add a new bookmark anymore. Nor via Menu, nor via Ctrl-B

Tested on a fresh build on Debian, and a fresh nightly on Windows today.

Also tested both with an existing profile AND a super fresh one.

---

• bookmar.png (Richard Duivenvoorde)

---

Related issue(s): #24885 (duplicates)
Redmine related issue(s): 16986

---

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)

---

Some extra testing:

• I can remove the one issue, and then create a new one.
• there is a checkbox 'In Project' which I cannot edit?

---

• 11736 was configured as bookmar.png

---

• bookmar.png (Richard Duivenvoorde)

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

I confirm: I neither can check it. Last week, it was possible to check that box but it resulted in #25369 (on Windows 10)
There are "some general issues with bookmarks":https://issues.qgis.org/projects/qgis/issues?utf8=%E2%9C%93&set_filter=1&f%5B%5D=status_id&op%5Bstatus_id%5D=o&f%5B%5D=description&op%5Bdescription%5D=%7E&v%5Bdescription%5D%5B%5D=bookmark&f%5B%5D=tracker_id&op%5Btracker_id%5D=%3D&v%5Btracker_id%5D%5B%5D=1&f%5B%5D=&c%5B%5D=tracker&c%5B%5D=status&c%5B%5D=priority&c%5B%5D=subject&c%5B%5D=assigned_to&c%5B%5D=updated_on&group_by= creation, update, removal that render the tool less usable:

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

I confirm: I neither can check it.
Oups, sorry. I realized that no project was open in the QGIS instance I was trying to check the bookmark's box in. Opening a project made the checkbox available here. But I can't uncheck those already checked.

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• priority_id was changed from Normal to High
• regression was changed from 0 to 1

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

looking ...

---

• assigned_to_id was configured as Alessandro Pasotti

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)

---

@alessandro, see also https://lists.osgeo.org/pipermail/qgis-developer/2017-November/050696.html

I think the actual functionality/user experience is a little smelly too

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Thanks Richard, I saw that email. Btw, the whole bookmarks functionality was badly broken in master, I'm almost done with fixing it, I'll commit soon.

---

• status_id was changed from Open to In Progress

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

PR #5765

---

• pull_request_patch_supplied was changed from 0 to 1

[qgib]

Author Name: Anónimo (Anónimo)

---

Applied in changeset 7e711f1.

---

• status_id was changed from In Progress to Closed
• done_ratio was changed from 0 to 100

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)

---

Reopening, as still things are not going well.

First: thanks for showing the actual epsg-code in the SRID table now!! Much better then the internal crs id it was before!

Things that go wrong with me here:

1. checkbox is not checkable unless you restart QGIS. To reproduce:

• make sure you do not have any profile info (I removed .qgis2, ~/.local/share/QGIS AND .config/QGIS)
• open QGIS, add a layer to the fresh project
• create a bookmark
• checkbox is (rightfully) uncheckable/inactive because the project is not named/saved yet
• now save the project by giving it a name
• the checkbox does not become checkable
• not even if you start a new project, and then reopen the first project
• it becomes checkable when you close QGIS and open the project again

2. as soon as you have opened one project, you can use the checkboxes, BUT if you create a new project and select one of the earlier bookmarks (which should not be checkable, as there is NOT a saved project), and you check some bookmarks, AND close QGIS without saving the project to disk. Then open QGIS and the bookmarks are gone (and nowhere saved....)

As said earlier, I think there has not been enough thought one how this could/should be used and all the implications of checking/deleting bookmarks.

Not sure if above issues are fixable easily (I doubt), but current model-merging is not optimal (to be positive). I would think that there should actually 2 tables in the Spatial Bookmarks Panel: one for global bookmarks (saved in qgis.sqlite) and one saved in the project/project file. Then you can ONLY copy a bookmark from one table to the other, and ONLY delete it in one of the two tables (being the qgis-model and the project-model). Opening a fresh project opens (off course) the qgis-model and a fresh project-model. Opening an excisting project opens both.
No need for merging or synchronizing (which is always hell)...

Thoughts?

---

• status_id was changed from Closed to Reopened

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

First, instead of re-opening this ticket (whose title and description are "I can only create one spatial..." and appears to be actually fixed) you should create separate tickets, for separate issues.

Thas said, I agree that the current merged model is a bit overcomplicated: it took me a while to fix it.

But please, close this one and file another ticket, I'll see what I can do to fix the "in project" issue while I'm am fresh.

[qgib]

Author Name: Richard Duivenvoorde (@rduivenvoorde)

---

See #25481

Closing this one as THIS actual issue is fixed.

---

• status_id was changed from Reopened to Closed

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

• duplicates was configured as a new bookmark is apparently not created after the first one, if only QGIS bookmarks are present #24885

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• resolution was changed from to fixed/implemented