Crash when clicking browse button in attachment edit widget (PLEASE RE-ADD THE BUTTON) #26948

qgib · 2018-06-05T12:22:01Z

26.7.2019 - @m-kuhn

The browse button has been removed as a band aid to prevent the crash.
Fixing the browse button will require additional work based on the analysis in #26948 (comment) .

Author Name: Tom Chadwin (@tomchadwin)
Original Redmine Issue: 19118
Affected QGIS version: 3.7(master)
Redmine category:edit_widget

Steps to recreate:

Open a vector layer with at least one text field
Change a text field's edit widget to Attachment
Open the layer's attribute table
Toggle editing
Highlight a value in the column whose edit widget you just changed
Click the ellipsis browse button

On Win 7 and 10, we have confirmations that this causes a full QGIS crash, with no QGIS crash handler.

2019-01-29_09-29-35.gif (Tom Chadwin)
Screenshot_2019-05-22_11-37-15.png (Grga Franges)

Related issue(s): #27961 (duplicates), #29182 (duplicates), #29271 (duplicates), #29408 (duplicates), #29590 (relates)
Redmine related issue(s): 20140, 21365, 21454, 21592, 21775

qgib · 2018-06-05T12:24:06Z

Author Name: Tom Chadwin (@tomchadwin)

Confirmed by Harrissou: http://irclogs.geoapt.com/qgis/%23qgis.2018-06-05.log

qgib · 2018-06-08T15:05:22Z

Author Name: Matthias Kuhn (@m-kuhn)

Cannot reproduce on Linux/master

qgib · 2018-06-30T11:09:07Z

Author Name: Tom Chadwin (@tomchadwin)

Crash still occurs in 3.2 and recent nightly. Using QGIS sample Alaska airports dataset, changing "USE" widget to Attachment, enabling editing, selecting the USE field of the NOATAK record, and clicking the browse button. Win7 x64.

qgib · 2018-09-18T10:23:39Z

Author Name: T Dunne (T Dunne)

Still an issue.

Sometimes clicking the button does not cause a crash but adding an attachment does.

qgib · 2018-11-06T09:40:06Z

Author Name: Tom Chadwin (@tomchadwin)

Issue still present in 3.4.1

qgib · 2018-11-06T10:54:40Z

Author Name: Giovanni Manghi (@gioman)

version was changed from 3.0.3 to 3.4.1

qgib · 2019-01-24T10:40:00Z

Author Name: Benjamin Jakimow (@jakimowb)

Issue still present in 3.4.4

qgib · 2019-01-24T11:18:40Z

Author Name: Jürgen Fischer (@jef-n)

duplicated was configured as QgsExternalResourceWidgetWrapper crashes #27961

qgib · 2019-01-29T08:38:24Z

Author Name: Peter Petrik (@PeterPetrik)

unable to reproduce on Mac with 3.5 master

qgib · 2019-01-29T08:51:43Z

Author Name: Giovanni Manghi (@gioman)

status_id was changed from Open to Feedback

qgib · 2019-01-29T08:55:50Z

Author Name: Tom Chadwin (@tomchadwin)

@giovanni What feedback is needed - happy to help test.

qgib · 2019-01-29T09:32:18Z

Author Name: Tom Chadwin (@tomchadwin)

14190 was configured as 2019-01-29_09-29-35.gif

2019-01-29_09-29-35.gif (Tom Chadwin) - Screencast GIF of steps to reproduce this crash

qgib · 2019-01-29T09:33:46Z

Author Name: Tom Chadwin (@tomchadwin)

Confirmed issue still present in 3.4.4 Win7 x64, as reported by @benjamin Jakimow

qgib · 2019-01-29T09:42:25Z

Author Name: Giovanni Manghi (@gioman)

Tom Chadwin wrote:

@giovanni What feedback is needed - happy to help test.

if a developer is having a look at the issue but is unable to replicate then is requested to the issuer to check again and/or improve the description (or as in your case add a screencast).

qgib · 2019-01-29T09:42:48Z

Author Name: Giovanni Manghi (@gioman)

status_id was changed from Feedback to Open

qgib · 2019-01-29T13:59:05Z

Author Name: Peter Petrik (@PeterPetrik)

probably windows-only issue :)

qgib · 2019-03-05T11:17:37Z

Author Name: Samuel Wechsler (Samuel Wechsler)

still an issue in the current nightly built 3.7.0-Master (QGIS code revision 34a0650). And yes I use windows.

qgib · 2019-03-05T14:30:11Z

Author Name: Giovanni Manghi (@gioman)

also on linux.

operating_system was changed from Windows 7, Windows 10 to
version was changed from 3.4.1 to 3.7(master)

qgib · 2019-03-05T14:30:56Z

Author Name: Giovanni Manghi (@gioman)

duplicated was configured as instant crash when using the "attachment" widget #29271

qgib · 2019-03-05T14:31:59Z

Author Name: Tom Chadwin (@tomchadwin)

@giovanni Manghi That's the first report of this on non-Windows.

qgib · 2019-03-15T09:40:50Z

Author Name: Giovanni Manghi (@gioman)

duplicated was configured as QGIS crash when opening file browser from attachment field in attribute table #29408

qgib · 2019-03-15T09:41:23Z

Author Name: Giovanni Manghi (@gioman)

duplicated was configured as QGIS crashes with web view attachment widget in a relation widget in the attribute form #29182

qgib · 2019-05-22T09:41:32Z

Author Name: Grga Franges (Grga Franges)

Several bug reports have been marked as duplicates and merged with this one, but i feel it's description doesnt represent the full extent of this bug.

In my case crash happens whenever an entry is changed in an attachment widget with a web view document viever. Crash also happens when you switch to another feature in attribute table form view. (see attached image)

I have found this bug in 3.4. LTR on Mint 19, Windows 7 and Windows 10 environments. It totally ruins our organisation's usage scenario for QGIS and has caused us great pain. It is a regression from an important feature that used to work perfectly in 2.18.

It would be nice if we could at least get some update here on what is causing the issue and what are the prospects of resolving it.

14971 was configured as Screenshot_2019-05-22_11-37-15.png

Screenshot_2019-05-22_11-37-15.png (Grga Franges)

qgib · 2019-05-23T09:35:53Z

Author Name: Alessandro Pasotti (@elpaso)

relates was configured as qgis crash when filtering a layer with an attachment field #29590

m-kuhn · 2019-07-26T07:52:10Z

The browse button has been removed as a band aid to prevent the crash.
Fixing the browse button will require additional work based on the analysis #26948 (comment)

gioman · 2019-07-26T07:52:56Z

The browse button has been removed as a band aid to prevent the crash.

The discussion was ongoing, was not ended. Please revert.

gioman · 2019-07-26T08:08:27Z

I re-changed the title because the button must be re-enabled at some point. The patch just put the dirt under the rug and we must not forget about this dirt.

jukos · 2019-08-08T18:43:24Z

Same bug for QGIS 3.4.x with Windows 10 and QGIS 3.8.1 with Ubuntu 18.04

m-kuhn · 2019-08-10T07:59:28Z

#30944 and #30945 avoid the crash by hiding the button in 3.4 and 3.8. They will be merged in the upcoming days if not magically a solution for the underlying problem appears.

nirvn · 2019-08-10T08:03:16Z

+1; the most promising (and possibly only?) path forward identified here is to hire the KDAB folks, and it won't happen prior to next point release in six days.

When showing a file dialog, Qt can choose to use the "system" file dialog, which will make QgsExternalResourceWidget to loose the focus. This patch blocks all the events that are sent to QgsExternalResourceWidget while a dialog is shown, this way it will keep the focus until the dialog is closed. Sponsored by the QGIS project (qgis.org) Fixes: qgis#26948

When showing a file dialog, Qt can choose to use the "system" file dialog, which will make QgsExternalResourceWidget to loose the focus. This patch blocks all the events that are sent to QgsExternalResourceWidget while a dialog is shown, this way it will keep the focus until the dialog is closed. Sponsored by the QGIS project (qgis.org) Fixes: #26948

gioman · 2019-09-22T16:36:53Z

m-kuhn closed this in #31905 2 hours ago

@m-kuhn how the fix works? does it brings back the button?

m-kuhn · 2019-09-22T16:43:56Z

yes

gioman · 2019-09-22T16:46:23Z

yes

@m-kuhn that is great news Matthias! so... the fix was only in QGIS code or it needed also an upstream fix?

m-kuhn · 2019-09-22T16:53:52Z

Thanks to the awesome work of @bog-dan-ro a band-aid inside QGIS could be added (along the lines of the proposal here)

When showing a file dialog, Qt can choose to use the "system" file dialog, which will make QgsExternalResourceWidget to loose the focus. This patch blocks all the events that are sent to QgsExternalResourceWidget while a dialog is shown, this way it will keep the focus until the dialog is closed. Sponsored by the QGIS project (qgis.org) Fixes: #26948

jukos · 2019-09-22T20:51:43Z

Hmm. Sounds good.
And with this improvement it is now possible to use qgis2web fully?
https://gis.stackexchange.com/questions/310446/no-images-in-popups-only-url-is-displayed/310974#310974
https://issues.qgis.org/issues/19118

If yes: With the next qgis version?

Thank you and greetings, Jürgen

m-kuhn · 2019-09-23T05:15:21Z

@tomchadwin might be able to comment on that.
As far as I understood him last time this issue was only loosely coupled to this missing functionality on qgis2web.

tomchadwin · 2019-09-23T08:23:46Z

@jukos, @m-kuhn Yes, this should bring images in popups back to life in qgis2web. However, no doubt there will be issues at the qgis2web end by now, as I've not looked at that code for a long time. Now that we have the QGIS bug fixed, and once you have a working version of QGIS with that fix, let's continue the discussion back on the qgis2web repo.

Huge thanks to @bog-dan-ro fir the fix - it's great to be able to bring this functionality back to life again, and I'm really grateful. Thanks also to @m-kuhn for his thorough investigation and temporary fix.

gioman · 2019-09-23T08:31:38Z

a band-aid inside QGIS could be added (along the lines of the proposal here)

Thanks to everyone that put an effort on this, it won't certainly feel as a band aid to all the users that have now their workflow restored at the same state they had on the old ltr.

jukos · 2019-09-24T16:55:37Z

@m-kuhn
Is the new improvement included within this weekly-version?:
QGIS-OSGeo4W-3.9.0-38-Setup-x86.exe | 24-Sep-2019 15:14 | 411M |

Thank you and greetings

m-kuhn · 2019-09-25T05:46:12Z

I assume so, yes.
Can you test and report back?

m-kuhn · 2019-09-25T06:22:38Z

@jukos some clarification:

@jukos the missing functionality to show photos inside qgis2web popups was never directly coupled to this QGIS issue on a technical level. The fix in the latest QGIS versions fixes a button inside QGIS (which is very nice!), but nothing on the qgis2web end. The issue there still needs to be fixed.

jukos · 2019-09-25T06:31:49Z

OK. In my first test yesterday I saw no images....

The issue there still needs to be fixed.

When? / What is the next procedure?

This issue is closed. Which qgis-issue for this problem is "open"?

Thank you and greetings

m-kuhn · 2019-09-25T06:39:00Z

There are two things here:

The button inside QGIS which crashed. Can you confirm it works again as expected?
The qgis2web functionality. There is no open issue for that here, because there is nothing we can do from QGIS side to solve this. Please follow up on the open issue at qgis2web Photos not showing in popup qgis2web/qgis2web#661 . Neither this QGIS issue nor any other QGIS issue (I am aware of) should be blocking anything there (and in fact they did never block anything there on a technical level) :)

jukos · 2019-09-25T06:56:37Z

I can use the button for insert and changes of attachment-photos without crash.
OK. Maybe Tom Chadwin has time the next days....

qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Forms Crash/Data Corruption Regression Something which used to work, but doesn't anymore labels May 25, 2019

qgib mentioned this issue May 25, 2019

QgsExternalResourceWidgetWrapper crashes #27961

Closed

gioman changed the title ~~Browse button missing in attachment edit widget~~ Crash when clicking browse button in attachment edit widget Jul 26, 2019

gioman changed the title ~~Crash when clicking browse button in attachment edit widget~~ Crash when clicking browse button in attachment edit widget (PLEASE RE-ADD THE BUTTON) Jul 27, 2019

m-kuhn added the Upstream Needs changes in an upstream library (like Qt, Proj, GDAL, ...) label Aug 14, 2019

bog-dan-ro mentioned this issue Sep 20, 2019

Block the events while showing a dialog #31905

Merged

6 tasks

m-kuhn closed this as completed in #31905 Sep 22, 2019

jukos mentioned this issue Sep 24, 2019

Photos not showing in popup qgis2web/qgis2web#661

Closed

Crash when clicking browse button in attachment edit widget (PLEASE RE-ADD THE BUTTON) #26948

Crash when clicking browse button in attachment edit widget (PLEASE RE-ADD THE BUTTON) #26948

Comments

qgib commented Jun 5, 2018 • edited by m-kuhn Loading

qgib commented Jun 5, 2018

qgib commented Jun 8, 2018

qgib commented Jun 30, 2018

qgib commented Sep 18, 2018

qgib commented Nov 6, 2018

qgib commented Nov 6, 2018

qgib commented Jan 24, 2019

qgib commented Jan 24, 2019 • edited Loading

qgib commented Jan 29, 2019

qgib commented Jan 29, 2019

qgib commented Jan 29, 2019

qgib commented Jan 29, 2019

qgib commented Jan 29, 2019

qgib commented Jan 29, 2019

qgib commented Jan 29, 2019

qgib commented Jan 29, 2019

qgib commented Mar 5, 2019

qgib commented Mar 5, 2019

qgib commented Mar 5, 2019 • edited Loading

qgib commented Mar 5, 2019

qgib commented Mar 15, 2019 • edited Loading

qgib commented Mar 15, 2019 • edited Loading

qgib commented May 22, 2019

qgib commented May 23, 2019 • edited Loading

m-kuhn commented Jul 26, 2019

gioman commented Jul 26, 2019

gioman commented Jul 26, 2019

jukos commented Aug 8, 2019

m-kuhn commented Aug 10, 2019

nirvn commented Aug 10, 2019

gioman commented Sep 22, 2019

m-kuhn commented Sep 22, 2019

gioman commented Sep 22, 2019

m-kuhn commented Sep 22, 2019

jukos commented Sep 22, 2019 • edited Loading

m-kuhn commented Sep 23, 2019

tomchadwin commented Sep 23, 2019

gioman commented Sep 23, 2019

jukos commented Sep 24, 2019 • edited Loading

m-kuhn commented Sep 25, 2019

m-kuhn commented Sep 25, 2019

jukos commented Sep 25, 2019 • edited Loading

m-kuhn commented Sep 25, 2019

jukos commented Sep 25, 2019 • edited Loading

qgib commented Jun 5, 2018 •

edited by m-kuhn

Loading

qgib commented Jan 24, 2019 •

edited

Loading

qgib commented Mar 5, 2019 •

edited

Loading

qgib commented Mar 15, 2019 •

edited

Loading

qgib commented Mar 15, 2019 •

edited

Loading

qgib commented May 23, 2019 •

edited

Loading

jukos commented Sep 22, 2019 •

edited

Loading

jukos commented Sep 24, 2019 •

edited

Loading

jukos commented Sep 25, 2019 •

edited

Loading

jukos commented Sep 25, 2019 •

edited

Loading