Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore out of range option in interpolated symbol renderer creates artifacts if start value is out of range #46362

Closed
1 of 2 tasks
DelazJ opened this issue Dec 4, 2021 · 4 comments · Fixed by #47174
Closed
1 of 2 tasks
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers

Comments

@DelazJ
Copy link
Contributor

DelazJ commented Dec 4, 2021

What is the bug or the crash?

In line symbol interpolated rendering type, if start value is lower than min value and you check "Ignore out of range", then you get weird lines from the start point to the top left corner of the canvas for every feature whose start point satisfies this condition.

In the attached screen cast I'm using a field but i realized afterwards that using direct numbers generates the same issue as well as having start value greater than the max value. No issue afaict with end value being lower than min value or greater than max.

Steps to reproduce the issue

interpolated

Versions

<style type="text/css"> p, li { white-space: pre-wrap; } </style>
QGIS version 3.22.0-Białowieża QGIS code branch Release 3.22
Qt version 5.12.8
Python version 3.8.10
GDAL/OGR version 3.0.4
PROJ version 6.3.1
EPSG Registry database version v9.8.6 (2020-01-22)
Compiled against GEOS 3.8.0-CAPI-1.13.1 Running against GEOS 3.8.0-CAPI-1.13.1
SQLite version 3.31.1
PostgreSQL client version 12.8 (Ubuntu 12.8-0ubuntu0.20.04.1)
SpatiaLite version 4.3.0a
QWT version 6.1.4
QScintilla2 version 2.11.2
OS version Ubuntu 20.04.3 LTS
       
Active Python plugins
trackable_project_files v1.2.2
MapsPrinter 0.6
MemoryLayerSaver 4.0.4
db_manager 0.1.20
processing 2.12.99

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

No response

@DelazJ DelazJ added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Dec 4, 2021
@gioman gioman added the Symbology Related to vector layer symbology or renderers label Dec 4, 2021
@elpaso
Copy link
Contributor

elpaso commented Feb 2, 2022

What is the expected behavior of "out of range" ? Should it skip the points of the line which are (interpolated) out of range?

@DelazJ
Copy link
Contributor Author

DelazJ commented Feb 3, 2022

Yes, from my understanding. See https://docs.qgis.org/3.22/en/docs/user_manual/style_library/symbol_selector.html#line-symbols (not the most direct URL but...)
@vcloarec might know better.

@elpaso
Copy link
Contributor

elpaso commented Feb 3, 2022

@DelazJ do you know if is there a reason for calling it "Clip out of range values" here?

immagine

@elpaso
Copy link
Contributor

elpaso commented Feb 3, 2022

I see the behavior is different indeed, the varying width do not render at all the lines segments where one of the two points are out of range while the varying color interpolates, I'm not sure if they should behave the same.

elpaso added a commit to elpaso/QGIS that referenced this issue Feb 3, 2022
Fixes  qgis#46362

Also fixes an unreported issue where the "Ignore out of range" checkbox
is not correctly set when it should be checked.
nyalldawson pushed a commit that referenced this issue Feb 3, 2022
Fixes  #46362

Also fixes an unreported issue where the "Ignore out of range" checkbox
is not correctly set when it should be checked.
qgis-bot pushed a commit that referenced this issue Feb 3, 2022
Fixes  #46362

Also fixes an unreported issue where the "Ignore out of range" checkbox
is not correctly set when it should be checked.
nyalldawson pushed a commit that referenced this issue Feb 4, 2022
Fixes  #46362

Also fixes an unreported issue where the "Ignore out of range" checkbox
is not correctly set when it should be checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Symbology Related to vector layer symbology or renderers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants