[DB Manager] Fix delete raster layer in GeoPackage (Fix #57751)

[agiudiceandrea]

Description

Fixes the "Delete..." functionality for raster layers in GeoPackage containers.

Fixes #57751.

Looking at the reported issue, I noticed that also the "Rename..." functionality doesn't work for raster layers in GeoPackage containers (it is not possible to rename a raster layer in a GeoPackage container even using the Browser panel #30907).
@elpaso it looks like a renameRasterTable function is missing in QgsGeoPackageProviderConnection.
@rouault, is there a "simple" way to rename a raster layer in a GeoPackage? (it seems to me ALTER TABLE ... RENAME TO ... doesn't correctly work for raster layers in GeoPackage)

UPDATE: I've also removed the Rename action for raster layer in a GeoPackage.
UPDATE: I'll submit a new PR to fix the Rename action for raster layer in a GeoPackage.

[github-actions]

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit a840ebf)

[elpaso]

See: #30907 (comment)

[agiudiceandrea]

See: #30907 (comment)

This is not yet supported by GDAL.

I've also removed the Rename action for raster layer in a GeoPackage.

[rouault]

@rouault, is there a "simple" way to rename a raster layer in a GeoPackage?

no, it isn't supported currently. I've filed OSGeo/gdal#10201 about that

[agiudiceandrea]

Not sure if this is the best way to check if the item is a raster layer in a GeoPackage container...

[elpaso]

DB manager is ancient code, a more modern approach would be to use the connections API:

md = QgsProviderRegistry.instance().providerMetadata('postgres')
conn = md.createConnection("dbname='tinyows_demo' host=localhost port=5433 username='***' password='***'", {})
table = conn.table('public', 'demo3dlinestring')
bool(table.flags() & QgsAbstractDatabaseProviderConnection.TableFlag.Raster)
bool(table.flags() & QgsAbstractDatabaseProviderConnection.TableFlag.Vector)

It should work with all QGIS supported DB providers (GPKG included).

[elpaso]

@agiudiceandrea see OSGeo/gdal#10213

Maybe you can add a branch to check for the next GDAL version.

[agiudiceandrea]

@agiudiceandrea see OSGeo/gdal#10213

Maybe you can add a branch to check for the next GDAL version.

@elpaso thanks.
Do you plan to also add a renameRasterTable function in QgsGeoPackageProviderConnection? The DB Manager uses the renameVectorTable and renameRasterTable functions

QGIS/python/plugins/db_manager/db_plugins/gpkg/connector.py

Lines 621 to 624 in 164ba02

	if name in vector_table_names:
	self.core_connection.renameVectorTable('', name, new_table)
	else:
	self.core_connection.renameRasterTable('', name, new_table)

and I think that will be also useful in order to fix the raster layer renaming in the Browser (#30907).

[elpaso]

QgsGeoPackageProviderConnection

I will update QgsGeoPackageProviderConnection but a check for GDAL > 3.9.1 will be necessary.

[agiudiceandrea]

I will update QgsGeoPackageProviderConnection but a check for GDAL > 3.9.1 will be necessary.

@elpaso, thanks again. I see that OSGeo/gdal#10213 has not been backported to the GDAL 3.9 branch so I it looks like it will be available in GDAL >= 3.10.

Anyway I think it would be better if I remove the last commit [db manager] Don't add a Rename action for raster layer in GeoPackage from this PR so this PR can be merged now.
I will then open a new PR to fix the renaming action for raster layer in GeoPackage after QgsGeoPackageProviderConnection will be updated.

[agiudiceandrea]

Hi @elpaso, I've removed the second commit from this PR. So it now only fixes the Delete functionality and can be merged and backported.
I'll open a new PR to also fix the Rename functionality with GDAL >= 3.10 thanks to your PRs OSGeo/gdal#10213 and #57812. The new PR cannot be backported to 3.34 since #57812 has not been backported to 3.34.

[agiudiceandrea]

I'll open a new PR to also fix the Rename functionality with GDAL >= 3.10

PR: #57865.