Try to use the project CRS when adding a layer from the browser #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
assigned to @wonder-sk |
|
Code looks good to me, but I haven't had time to test it. Currently the PR cannot be automatically merged. When merging, please update SIP bindings and note that the new methods were added in 2.4. @mhugent ? |
|
Since qgisapp is not exposed in the python bindings, no updates to the sip files should be necessary. |
|
There are also changes to QgsDataItem and QgsMimeDataUtils which belong to the core library and they are exposed to Python... |
|
Ups yeah forgot about those. Fixed. |
|
@wonder-sk does this look good to you? |
|
Any chance this can get merged? |
mhugent
added a commit
that referenced
this pull request
Dec 23, 2014
Try to use the project CRS when adding a layer from the browser
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a layer is added from the browser, the first valid CRS is used. With this patch, the project CRS is used if possible. Also, the last selected image format is used if possible.
At the same time, proper escaping and unescaping routines are introduced, removing the need for the
if ( parts[3] == "PG" )workaround.Funded by Sourcepole QGIS Enterprise.