use QgsFieldExpressionWidget in data defined properties

[3nids]

This uses the new field expression widget in data defined properties for a better UI coherence.
I had to const_cast QgsVectorLayer because QgsDataDefinedSymbolDialog uses a const layer pointer.
BTW, this fixes the fact that the help for the name symbol was not fully readable (was multiline).

@mhugent since you designed, can you tell me if it's ok for you?

new dialog:

old dialog:

[NathanW2]

This looks good to me. In the future we should really do the same as the
label dialog because that UI is nicer IMO.
On May 15, 2014 5:09 PM, "Denis Rouzaud" notifications@github.com wrote:

This uses the new field expression widget in data defined properties for a
better UI coherence.
I had to const_cast QgsVectorLayer because QgsDataDefinedSymbolDialog uses
a const layer pointer.
BTW, this fixes the fact that the help for the name symbol was not fully
readable (was multiline).

@mhugent https://github.com/mhugent since you designed, can you tell me
if it's ok for you?

new dialog:
[image: image]https://cloud.githubusercontent.com/assets/127259/2981110/6fe0d5e6-dbff-11e3-838f-8ad7a7b701f0.png

old dialog:

[image: image]https://cloud.githubusercontent.com/assets/127259/2981097/3b527d20-dbff-11e3-98a3-02287f154b64.png

You can merge this Pull Request by running

git pull https://github.com/3nids/QGIS datadefined2

Or view, comment on, or merge it at:

#1352
Commit Summary

• use QgsFieldExpressionWidget in data defined properties

File Changes

• M src/gui/symbology-ng/qgsdatadefinedsymboldialog.cpphttps://github.com/use QgsFieldExpressionWidget in data defined properties #1352/files#diff-0(135)
• M src/gui/symbology-ng/qgsdatadefinedsymboldialog.hhttps://github.com/use QgsFieldExpressionWidget in data defined properties #1352/files#diff-1(7)
• M src/gui/symbology-ng/qgssymbollayerv2widget.cpphttps://github.com/use QgsFieldExpressionWidget in data defined properties #1352/files#diff-2(2)
• M src/ui/qgsdatadefinedsymboldialogbase.uihttps://github.com/use QgsFieldExpressionWidget in data defined properties #1352/files#diff-3(47)

Patch Links:

• https://github.com/qgis/QGIS/pull/1352.patch
• https://github.com/qgis/QGIS/pull/1352.diff

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1352
.

[nyalldawson]

Composer will soon use the label settings data defined button too, so it would be great to standardize on this. It would actually be a nice touch to make the expression button in the qgsfieldexpression widget use the label style control too, since it has nice handling of copying/pasting expressions and help for acceptable formats...

[3nids]

@NathanW2 totally agree
@nyalldawson I believe thes QgsFieldExpressionWidget and QgsDataDefinedButton are two different beasts and should not be mixed. Once the custom widget PR merge #1325, I will add the data defined button to the library.

[mhugent]

assigned to @m-kuhn