Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMS GetLegendGrapics: with LAYERFONTSIZE and ITEMFONTSIZE equal to 0, the labels should not be drawn. #1355

Closed
wants to merge 2 commits into from

Conversation

luca76
Copy link
Contributor

@luca76 luca76 commented May 15, 2014

As subject, for the WMS request GetLegendGrapics:
if I set LAYERFONTSIZE and ITEMFONTSIZE to 0, the labels should not be drawn.

Useful for Qgis Web Client, you can get the graphic of the symbol and put it in the layer tree (in the left panel) without labels, since there is already the layer name in the layer tree.

GetLegendGraphics: if LAYERFONTSIZE and ITEMFONTSIZE url parameters are equal to 0, do not draw legend labels.
@luca76
Copy link
Contributor Author

luca76 commented May 15, 2014

Here is a working example.

image

@mhugent mhugent self-assigned this May 15, 2014
@mhugent
Copy link
Contributor

mhugent commented May 15, 2014

assigned to @mhugent

@rldhont
Copy link
Contributor

rldhont commented May 15, 2014

Hi Luca,

Can you do a "git rebase -i master" to squash the commits
https://help.github.com/articles/interactive-rebase
And do a "git commit --amend" to have a more descriptive commit

Thanks

@rldhont
Copy link
Contributor

rldhont commented May 15, 2014

Tested with LizMap-Web-Client and it's what we expected

Thanks Luca

lizmap

@luca76
Copy link
Contributor Author

luca76 commented May 16, 2014

@rldhont thank you for your answer. I'm new to github, and maybe I made confusion with my pull request. I did all via github web (editing the file from web, the github made a fork and then finally I did a pull request). Is it wrong? Is there some tutorial on the correct way to do this? (command line version is accepted :D)

@luca76
Copy link
Contributor Author

luca76 commented May 19, 2014

@mhugent any news? It would be nice to have this pull request before string freeze. It would be a great addition, as you can see in the comments, for Qgis Web Server and Leaflet

@mhugent
Copy link
Contributor

mhugent commented May 19, 2014

@luca76 : no worry, it will be committed before feature freeze on Friday. I just think it would be more intuitive to have additional request parameters that tell to leave away layer title / item text (e.g. LAYERTITLE=false / RULELABEL=false). But that is only a minor change

@luca76
Copy link
Contributor Author

luca76 commented May 19, 2014

@mhugent you're right, those parameters (LAYERTITLE and RULELABEL) would be better. If you want, tomorrow I'll do a new pull request.
Another useful parameter should be the BACKGROUNDCOLOR: you can set it to a colour or transparency (for PNG files), if is not already possible to do so.

@luca76
Copy link
Contributor Author

luca76 commented May 20, 2014

I must correct myself (from last post): it is possible to enable transparency simply by adding "&TRANSPARENT=true" to the URL. So the background color is useless (it can easily be set in the HTML code)

@mhugent
Copy link
Contributor

mhugent commented May 20, 2014

Right.
Please also change the name of the member variables (drawLayer, drawItem) to something like mDrawLegendLayerLabel / mDrawLegendItemLabel so there is no confusion with other requests.

@luca76 luca76 closed this May 21, 2014
@luca76
Copy link
Contributor Author

luca76 commented May 21, 2014

@mhugent I closed this obsolete pull request, see the new pull request #1377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants