editor widgets: rename to wrapper to distinguish from the real widgets #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just took a short glance, but looks fine for me. |
|
Waiting for August 26, will be merged if no objection is risen on this thread: http://lists.osgeo.org/pipermail/qgis-developer/2014-August/034186.html |
|
+1 from me to merge |
|
manually merged in 92058f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed the xxxWidget classes to Wrapper, since they are not really the widgets and since they inherit the Wrapper.
The example is with the new relation reference widget where we have both widget and wrapper (see #1516).
This way, if we create custom widgets, like the color button, they can be named properly as Widget, and also have their wrapper properly named.
The change in API does not concern python since widgets/wrappers are not available (yet).
This concerns the C++ API (since 2.4), but the chance that someone used these widgets classes in a standalone app is quite close to 0.