Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating qwtpolar with latest source #1679

Closed
wants to merge 1 commit into from
Closed

updating qwtpolar with latest source #1679

wants to merge 1 commit into from

Conversation

mach0
Copy link
Member

@mach0 mach0 commented Nov 7, 2014

updated qwtpolar with latest source (currently 1.1.1) by copying source files into qwtpolar-1.0 folder and renaming the folder to qwtpolar-1.1 (as 1.0 is outdated anyway)
there is still the qwtpolar-0.1 folder inside (historical?) which could be deleted too.
Mentioned in #1676

Compiling perfectly on debian using internal qwtpolar .

Signed-off-by: Werner Macho werner.macho@gmail.com

updated qwtpolar with latest source (currently 1.1.1) by copying source files into qwtpolar-1.0 folder and renaming the folder to qwtpolar-1.1 (as 1.0 is outdated anyway)
there is still the qwtpolar-0.1 folder inside (historical?) which could be deleted too.

Signed-off-by: Werner Macho <werner.macho@gmail.com>
@mach0
Copy link
Member Author

mach0 commented Nov 7, 2014

should probably be tested on Windows and Mac

@m-kuhn m-kuhn removed their assignment Nov 7, 2014
@m-kuhn
Copy link
Member

m-kuhn commented Nov 7, 2014

Sorry @mach0

Better somebody if somebody using ubuntu takes care of that job.

@m-kuhn
Copy link
Member

m-kuhn commented Nov 7, 2014

See also #1676

Alternatives, quoted from #1676

  • Verify internal qwtpolar compatibility with Qt5 and update if appropriate
  • Build external packages for upstream (personal favorite)
  • Disable support for QWTPolar based features when external QWTPolar is unavailable

This PR implements the first solution, my personal favorite is another one

@mach0
Copy link
Member Author

mach0 commented Nov 7, 2014

I know - I mentioned #1676 , but as said .. debian has no qwtpolar package, and unless somebody creates either the package and/or rewrites the code to disable qwtpolar based features when external is not available (not really my favorite) we should at least keep the code updated .. :)

@jef-n
Copy link
Member

jef-n commented Nov 8, 2014

Updates to src/app/CMakeLists.txt missing, but QWT for Qt5 is also missing in debian

@m-kuhn
Copy link
Member

m-kuhn commented Dec 10, 2014

qwt6-qt5 is available in vivid (15.04)
Alternative approach would be to have a git submodule for qwtpolar.
My preferred approach would still be to make it an external dependency and optional.

@m-kuhn
Copy link
Member

m-kuhn commented Dec 10, 2014

See #1726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants