Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui context naming #2180

Closed
wants to merge 3 commits into from
Closed

Ui context naming #2180

wants to merge 3 commits into from

Conversation

rduivenvoorde
Copy link
Contributor

As a follow up of this thread:

https://lists.osgeo.org/pipermail/qgis-ux/2015-June/000329.html

and the feature request of Bernd:

https://hub.qgis.org/issues/8201

I add two commits here:

  • one to add 'Toolbar' + tooltips to all toolbars

selection_216

  • one to add 'Panel' to most(!) of the panels

Plz let's discuss if adding 'Panel' is needed, as it not only adds 'Panel' in the context, but also in the windowtitles:

selection_214

If people find the second commit TOO much I'm happy with only the first commit too....

@anitagraser
Copy link
Member

Thanks for adding this Richard! Personally, I don't mind reading "Panel" on the window titles if it makes the context menu better.

@DelazJ
Copy link
Contributor

DelazJ commented Jul 24, 2015

Hi,
Thank you, Richard! What about adding at the top of the context window "Panels" and after the separator "Toolbars" (let's say in bold or centered or whatever) so that people distinguished that the first part belongs to Panels while the second to Toolbars? No more need to add either toolbar nor panel to each item (or just to a few).

@m-kuhn
Copy link
Member

m-kuhn commented Jul 24, 2015

I have just pushed a quick implementation of @DelazJ s proposal. But I am not sure if I prefer it because personally I always mix up the terms toolbar and panel, so it would help my mind to read it in the title bar :P

@rduivenvoorde @anitagraser @DelazJ any preference? I am fine with either way and happy to merge it if somebody offers an opinion.

@rduivenvoorde
Copy link
Contributor Author

@m-kuhn can you plz share a screenshot?

Part of this PR is also that for the toolbars the 'handle' now has a tooltip. So sometimes you have these empty toolbars. Now when you hoover over them you see which one it is.

@m-kuhn
Copy link
Member

m-kuhn commented Jul 24, 2015

Yes, my commit does not fully replace this PR and the tooltip part will still need to be merged if the title approach (master) is preferred over the suffix approach (this PR).

untitled

@m-kuhn
Copy link
Member

m-kuhn commented Jul 24, 2015

Or a bit nicer :)

untitled

@anitagraser
Copy link
Member

+1 for the headers dividing the panels and toolbar section because I think it's visually clearer.

For me that doesn't necessarily mean that we cannot have titles which contain to words toolbar and panel as well if it makes things clearer.

@m-kuhn
Copy link
Member

m-kuhn commented Jul 24, 2015

I guess the question is, does it actually make things clearer. What's your opinion?

@rduivenvoorde
Copy link
Contributor Author

I think my PR fixes my problem: having nonnamed toolbars and not knowing how to remove them + all the items in the context menu, nog knowing which PE is which.
Adding Matthias titels makes it even better (his seconden try).
I'm in favour of merging both.

@anitagraser
Copy link
Member

The main advantage I see is that users get accustomed to the term "panel" if they see it in the UI more prominently.

@m-kuhn
Copy link
Member

m-kuhn commented Jul 24, 2015

Merged, thanks for the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants