Preserve 0/NULL values from postgres int columns #2207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly Currently failing
|
@m-kuhn should we also add an equality operator to QgsAttributes which can work around this upstream issue? |
|
BTW, thanks for looking into this. I'd also encountered this earlier in the week and was totally confused by what was happening... |
|
@nyalldawson like so? |
|
@m-kuhn looks good to me... I'm curious though, why go through the attributes backwards? |
|
@nyalldawson because the Qt QVector implementation does it that way :) |
|
@m-kuhn OK fair enough... Thought there may have been some complex c++ reason behind it :p the test + attribute changes should be safe to merge now, right? |
|
still struggling with sip... |
m-kuhn
force-pushed
the
pgfix
branch
4 times, most recently
from
ca6b939
to
69be0c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, the headline only says half of it. I think this patch is fine to apply but it does not solve the underlying problem.
It seems that the check on this line here fails to properly distinguish 0 from NULL in the attributes
https://github.com/qgis/QGIS/blob/master/src/core/qgsfeature.cpp#L97
We could as well remove the check and have some unnecessary detaches happen once in a while (not sure how often or bad that would be).
The underlying problem is that IIRC Qt returns true for
QVariant(int) == QVariant(0)a thing that should be solved upstream. We could maybe implement our own helper method to compare QVariants and have it take care of such things.@jef-n assigning you since you are the postgres provider wizard.
Thoughts?