Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple python tests of WFS responses #2583

Merged
merged 3 commits into from
Dec 15, 2015
Merged

Simple python tests of WFS responses #2583

merged 3 commits into from
Dec 15, 2015

Conversation

AsgerPetersen
Copy link
Contributor

No description provided.

rldhont
rldhont reviewed Dec 15, 2015
View reviewed changes
tests/src/python/test_qgsserver.py
project = self.testdata_path + "test+project_wfs.qgs"
assert os.path.exists(project), "Project file not found: " + project

query_string = 'MAP=%s&SERVICE=WFS&VERSION=1.1.0&REQUEST=%s' % (urllib.quote(project), request)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QGIS Server does not implement WFS 1.1.0.
Can you update this code ?

rldhont referenced this pull request Dec 15, 2015
@rldhont
[FEATURE][QGIS Server] STARTINDEX param in WFS GetFeature Request
30b3b68 
STARTINDEX is standard in WFS 2.0, but it's an extension for WFS 1.0 implemented in QGIS Server.

STARTINDEX can be used to skip some features in the result set and in combination with MAXFEATURES provides for the ability to use WFS GetFeature to page through results. Note that STARTINDEX=0 means start with the first feature, skipping none.
@rldhont rldhont added this to the 2.14 milestone Dec 15, 2015
@rldhont rldhont self-assigned this Dec 15, 2015
@rldhont rldhont merged commit 7101b5b into qgis:master Dec 15, 2015
@m-kuhn
Copy link
Member

m-kuhn commented Dec 15, 2015

@rldhont seems this has broken travis: https://travis-ci.org/qgis/QGIS/jobs/96995633#L1388

Please only merge pull requests which are green (unless there's a very good reason to assume that it's red for an unrelated reason and normally even in these cases it's worth restarting the tests once again to be certain).

@AsgerPetersen
Copy link
Contributor Author

@m-kuhn The failing test exposes a bug in QGIS server (which by the way was also fixed yesterday in a37ca2b).

Is there a more appropriate way to commit tests that expose bugs which are not yet fixed? It would be nice to be able to attach a failing test to a bug report.

@m-kuhn
Copy link
Member

m-kuhn commented Dec 16, 2015

You can add a test and mark it as @expectedFailure, so the test is already in master and ready once the issue is fixed. The problem with a test which fails and is in master is that it affects every new pull requests and masks possible issues there.

Therefore it's important to only have tests active that test for working functionality and if tests are in place for things to be fixed, it's important to raise awareness to have somebody fix it - or even better fix them right away like done here, thanks a lot 👍 !

@AsgerPetersen
Copy link
Contributor Author

Thanks. That is exactly the functionality I was after. I will never forget it :-)

@qgib qgib mentioned this pull request May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rldhont rldhont

Labels
None yet
Projects
None yet
Milestone
2.14
Development

Successfully merging this pull request may close these issues.
3 participants
@AsgerPetersen @m-kuhn @rldhont