Improvements and bugfixes for 2.5D renderer #2698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
force-pushed
the
25dimprovements
branch
2 times, most recently
from
88436b1
to
279ce83
Compare
|
@nirvn This fixes the renderer variables vs. layer variables issue |
|
@m-kuhn excellent. BTW, I filed a bug yesterday about the 2.5D symbology not loading properly on project load, worth testing if this moving to layer variables fixes that too. |
|
I hope so, that's why it says "Fixes #14132" |
m-kuhn
force-pushed
the
25dimprovements
branch
2 times, most recently
from
9ccd315
to
b6a62c4
Compare
|
Created using this pull request and a classification renderer |
|
@m-kuhn nice! |
m-kuhn
force-pushed
the
25dimprovements
branch
2 times, most recently
from
08470d7
to
ed9054c
Compare
* Move height and angle expressions for 2.5D renderer to layer * Apply color based on main symbol color This makes the transition to other renderers easy. Fixes qgis#14132
m-kuhn
force-pushed
the
25dimprovements
branch
from
ed9054c
to
dc95e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.