[Geometry checker] Make polyLineSize survive empty geometries #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me. you've got push rights, no? |
|
@m-kuhn is being too lenient... I'd like to see a unit test with this! I'm determined to make the geometry classes absolutely rock solid so having tests for all these rare corner cases would be fantastic. |
|
@nyalldawson I had the same thought but then I noticed it's in a plugin and forgot about it. |
|
Oh yeah.... @manisandro ignore me, I mistakenly thought this was in the core class, sorry! |
|
@m-kuhn Yes, got push rights, but a Qt5 test was failing over the weekend. Seems fixed now. |
manisandro
added a commit
that referenced
this pull request
Mar 14, 2016
[Geometry checker] Make polyLineSize survive empty geometries
|
That was unrelated to your code, the qt5 test still behaves flaky sometimes. I'm trying to figure out the reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes another geometry checker issue reported in bug #13535