-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single feature renderer symbol levels reset when changing style #31413
Conversation
* \param parent The parent symbol layer item. If the parent parameter is null, the whole symbol and model will be reset. | ||
* \note not available in Python bindings | ||
*/ | ||
void loadSymbol( QgsSymbol *symbol, SymbolLayerItem *parent = nullptr ) SIP_SKIP; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a TODO QGIS 4 note here saying "QGIS 4: transfer ownership of symbol", and in the dox note that ownership is NOT transferred and that the symbol MUST exist for the lifetime of the widget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport release-3_4
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 536987c05dac32820a8943b03c24d4edc32560c7 55465f928d1651986be7a2f2bc86c09cd25b3da5 8c7892a2c157642073a7346b885ba29237e394b6
# Create a new branch with these backported commits.
git checkout -b backport-31413-to-release-3_4
# Push it to GitHub.
git push --set-upstream origin backport-31413-to-release-3_4
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport release-3_8
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 536987c05dac32820a8943b03c24d4edc32560c7 55465f928d1651986be7a2f2bc86c09cd25b3da5 8c7892a2c157642073a7346b885ba29237e394b6
# Create a new branch with these backported commits.
git checkout -b backport-31413-to-release-3_8
# Push it to GitHub.
git push --set-upstream origin backport-31413-to-release-3_8
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
Description
This PR fixes #26547, whereas the symbol levels were reset to the values set when opening the style panel / layer properties window whenever the layer symbol was modified.
I've taken the opportunity to cleanup the symbol selector {widget, dialog} class a bit.
Checklist
Fixes #11111
at the bottom of the commit messagescripts/prepare-commit.sh
script before each commit