Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing Null representation in Range Widget on QgsDoubleSpinBox #32068

Merged
merged 4 commits into from
Oct 3, 2019

Conversation

signedav
Copy link
Contributor

Compared to the QgsSpinBox used for int values the Null representation did not disappear on QgsDoubleSpinBox used for double values:
Before:
before
After:
after

The feature has been implemented by me back then #8442 but obviously it contained a bug for QgsDoubleSpinBox.

I improved the tests for these cases.

This fixes #22883

@signedav signedav added backport release-3_4 Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Sep 30, 2019
@signedav
Copy link
Contributor Author

signedav commented Oct 1, 2019

Is one of you available to review that @luipir or @elpaso? (coming to you because you reviewed other PRs regarding this issue) Would be great.

@luipir
Copy link
Contributor

luipir commented Oct 1, 2019

hard period for me @signedav sorry... I'll do the best, but I can't be sure to be able.

@nyalldawson
Copy link
Collaborator

Can you remove the backport label please? This isn't serious enough to warrant a backport.

Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nyalldawson nyalldawson merged commit 1cd73a7 into qgis:master Oct 3, 2019
@signedav
Copy link
Contributor Author

signedav commented Oct 3, 2019

Thanks @elpaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"NULL" text in null field should disappear as soon as a field gets the focus
4 participants