Fix color widgets incorrectly change colors when mouse is hovered over widget #47069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cause for this issue -- the code was wrong, but the issue wasn't visible as the widgets would only start "tracking" the mouse after the widget was clicked and grabbed the mouse cursor. Changes elsewhere (in QgsScrollArea) mean that the scroll area children are always mouse tracking, so we need to fix the broken code and only allow the widget to change in between mouse left press/release pairs. |
|
wow thanks @nyalldawson ! |
|
By the just to confirm, I tested with your branch and the fix works nicely, thanks! |
|
Thanks for the confirmation @timlinux ! |
nirvn
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.