Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DistanceWithin algorithm with PostgreSQL provider (backport) #47076

Merged
merged 8 commits into from
Jan 31, 2022

Conversation

nyalldawson
Copy link
Collaborator

Manual backport of #46971

@nyalldawson nyalldawson added the Backport Is a backport of another pull request label Jan 31, 2022
@github-actions github-actions bot added this to the 3.24.0 milestone Jan 31, 2022
strk and others added 8 commits January 31, 2022 12:48
…ethod

Includes unit test

The equality operator is useful for unit tests, the inequality
operator was added for completeness as requested by Nyall
in qgis#45384 (comment)

(cherry picked from commit 182732e)
Equality useful for unit tests, inequality for completeness

(cherry picked from commit 95be545)
Tests the default constructor, the copy constructor and
the assignment operator.

(cherry picked from commit 2ea5c99)
This is a test for the bug reported in qgis#45352
Tests matching and mismatching CRS for target and reference layers

(cherry picked from commit edfccd9)
The method superceeds filterRectToSourceCrs, deprecating it for
shortage of functionality now that we support multiple spatial
filters.

This commit makes use of the new method from
QgsVectorLayerFeatureIterator::QgsVectorLayerFeatureIterator
so to not drop the WithinDistance spatial filter from the
user Request.

References qgis#45352

(cherry picked from commit 3004fde)
We can't safely handle a distance within query when transforming, as
we cannot transform the static within tolerance distance from one
CRS to a static distance in a different CRS

(cherry picked from commit 8e04498)
Copy link
Contributor

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@strk strk merged commit 596153a into qgis:queued_ltr_backports Jan 31, 2022
@nyalldawson nyalldawson deleted the backport_46971 branch May 28, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Is a backport of another pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants