Fix DistanceWithin algorithm with PostgreSQL provider (backport) #47076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
force-pushed
the
backport_46971
branch
from
23acf3f
to
4647e0e
Compare
(cherry picked from commit 31a97bd)
(cherry picked from commit 9ce1664)
…ethod Includes unit test The equality operator is useful for unit tests, the inequality operator was added for completeness as requested by Nyall in qgis#45384 (comment) (cherry picked from commit 182732e)
Equality useful for unit tests, inequality for completeness (cherry picked from commit 95be545)
Tests the default constructor, the copy constructor and the assignment operator. (cherry picked from commit 2ea5c99)
This is a test for the bug reported in qgis#45352 Tests matching and mismatching CRS for target and reference layers (cherry picked from commit edfccd9)
The method superceeds filterRectToSourceCrs, deprecating it for shortage of functionality now that we support multiple spatial filters. This commit makes use of the new method from QgsVectorLayerFeatureIterator::QgsVectorLayerFeatureIterator so to not drop the WithinDistance spatial filter from the user Request. References qgis#45352 (cherry picked from commit 3004fde)
We can't safely handle a distance within query when transforming, as we cannot transform the static within tolerance distance from one CRS to a static distance in a different CRS (cherry picked from commit 8e04498)
nyalldawson
force-pushed
the
backport_46971
branch
from
4647e0e
to
d8e238d
Compare
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #46971