Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text improvements for crash handler dialog #47107

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

timlinux
Copy link
Member

Description

The crash handler text was a bit awkward to read so I gave it a bit of an overhaul. This is how it looked before:

image

And this is how it looks with my changes:

crashhandler

@timlinux timlinux added the GUI/UX Related to QGIS application GUI or User Experience label Jan 31, 2022
@nyalldawson
Copy link
Collaborator

Hey @timlinux if you remove ALL the custom palette elements from the .ui file does it fix the theming issue?

Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes!

@nyalldawson nyalldawson enabled auto-merge (rebase) January 31, 2022 23:34
@nyalldawson
Copy link
Collaborator

...we need a sad face variant of the QGIS logo for this dialog ...

@github-actions github-actions bot added this to the 3.24.0 milestone Jan 31, 2022
@timlinux
Copy link
Member Author

timlinux commented Feb 1, 2022

...we need a sad face variant of the QGIS logo for this dialog ...

@raymondnijssen can you help us here?

@timlinux
Copy link
Member Author

timlinux commented Feb 1, 2022

Hey @timlinux if you remove ALL the custom palette elements from the .ui file does it fix the theming issue?

@nyalldawson ooh yeah that helps a lot:

image

@timlinux
Copy link
Member Author

timlinux commented Feb 1, 2022

Hey @timlinux if you remove ALL the custom palette elements from the .ui file does it fix the theming issue?

@nyalldawson ooh yeah that helps a lot:
I see you already took out the palette in #47110, thanks!

@nyalldawson nyalldawson merged commit 76ac6c5 into qgis:master Feb 1, 2022
@timlinux timlinux deleted the crash-handler branch February 1, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants