Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add copy to clipboard function to save as image #4914

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jul 24, 2017

Description

QGIS map canvas -> clipboard -> office suite! 😄

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@gioman
Copy link
Contributor

gioman commented Jul 24, 2017

very cool, thanks!

@nirvn
Copy link
Contributor Author

nirvn commented Jul 24, 2017

@gioman , big thanks to @andreasneumann for supporting this feature.

@NathanW2
Copy link
Member

NathanW2 commented Jul 24, 2017 via email

img = new QImage( ms.outputSize(), QImage::Format_ARGB32 );
if ( img->isNull() )
{
return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe push an error to the message bar if this happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nirvn
Copy link
Contributor Author

nirvn commented Jul 24, 2017

Obligatory screencast: https://www.youtube.com/watch?v=wWKzeG9zr1A

@3nids
Copy link
Member

3nids commented Jul 24, 2017

good job
does it work in Microsoft Words too? 😜

@NathanW2
Copy link
Member

NathanW2 commented Jul 24, 2017 via email

@nirvn nirvn merged commit 778e84b into qgis:master Jul 25, 2017
@nirvn nirvn deleted the clipboard branch February 26, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants