Fix: PostgreSQL provider force read-only and in recovery #50186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rldhont
added
Data Provider
|
Better add some unit tests as penance 😉 |
rldhont
force-pushed
the
postgres-forcereadonly-inrecovery
branch
4 times, most recently
from
07d1639
to
4f5088c
Compare
The PR *feat: Open layers in a read only mode with Qgis::ProjectReadFlag::ForceReadOnlyLayers* qgis#49440 contains an error when checking write capabilities. The write capabilities has to be checked when the database is not in recovery and when the provider is not forced to be in read-only. The old code checks the write capabilities when the provider is not forced to be in read-only or the database is not in recovery.
rldhont
force-pushed
the
postgres-forcereadonly-inrecovery
branch
from
4f5088c
to
08ecac9
Compare
|
@nyalldawson tests for postgres provider added |
nyalldawson
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR feat: Open layers in a read only mode with Qgis::ProjectReadFlag::ForceReadOnlyLayers #49440 contains an error when checking write capabilities.
The write capabilities has to be checked when the database is not in recovery and when the provider is not forced to be in read-only. The old code checks the write capabilities when the provider is not forced to be in read-only or the database is not in recovery.