Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract httpheaders when creating QgsDataSourceUri from string #51423

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

benoitdm-oslandia
Copy link
Contributor

@benoitdm-oslandia benoitdm-oslandia commented Jan 10, 2023

When QgsDataSourceUri was built from uri (like previously serialized to space delimiter form), httpHeaders were not extracted. This induced partial uri and therefore invalid network requests.

PR needs to be backported

fix #51409

@benoitdm-oslandia benoitdm-oslandia self-assigned this Jan 10, 2023
@github-actions github-actions bot added this to the 3.30.0 milestone Jan 10, 2023
@troopa81 troopa81 added backport queued_ltr_backports Queued Backports backport release-3_28 Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Jan 10, 2023
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Can you add some tests please?

@nyalldawson nyalldawson removed the backport queued_ltr_backports Queued Backports label Jan 10, 2023
@agiudiceandrea
Copy link
Contributor

The backport to release-3_22 is not needed, since the issue doesn't occur in QGIS 3.22.

@benoitdm-oslandia
Copy link
Contributor Author

@nyalldawson test added! Is it ok for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcGIS REST provider Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST server not loading in 3.28 Firenze but work fine in previous versions
4 participants