Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise legend filter by map/expression calculations #51675

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

nyalldawson
Copy link
Collaborator

Use optimised approach which hands off the heavy lifting to the data providers, so that the filter can be handled on the backend in many cases.

Refs #51233

filter

This can avoid unnecessary fetching and testing of many features
for eg categorised/rule based renderers which don't display all
features in the layer
these can be compiled and executed on the backend instead of
requesting all features and testing client side
@nyalldawson nyalldawson added the Optimization I feel the need... the need for speed! label Feb 1, 2023
@github-actions github-actions bot added this to the 3.30.0 milestone Feb 1, 2023
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement / cleanup.

@nyalldawson nyalldawson merged commit 0c52f51 into qgis:master Feb 1, 2023
@nyalldawson nyalldawson deleted the faster_hit_test branch February 1, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization I feel the need... the need for speed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants