OGR CSV: fix slow update #51686
Merged
OGR CSV: fix slow update #51686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpaso
added
the
Bug
elpaso
force-pushed
the
bugfix-gh51668-ogr-csv-slow-update
branch
from
508e1dd
to
923d7d9
Compare
pathmapper
reviewed
Feb 1, 2023
There was a problem hiding this comment.
Nice! With this fix saving the new-field-update of the sample data of #51668 is very fast 👍
Saved also other updates like single and multiple field edits or deleted fields -> everything worked fine, no negative side effects so far.
rouault
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #51668