Fix WFS cached feature iterator empty filter rect

[elpaso]

Fix #51492

Maybe an upstream (GEOS) issue, this is workaround.

This fails also using ogr:

poly = ogr.CreateGeometryFromWkt('POLYGON((0 0, 0 2, 2 2, 2 0, 0 0))')
multi_poly = ogr.CreateGeometryFromWkt('MULTIPOLYGON(((0 0, 0 2, 2 2, 2 0, 0 0)))')
bbox = ogr.CreateGeometryFromWkt('POLYGON((1 1, 1 1, 1 1, 1 1, 1 1))')
point = ogr.CreateGeometryFromWkt('POINT(1 1)')
assert poly.Intersects(point)
assert poly.Intersects(bbox)
assert multi_poly.Intersects(point)
assert multi_poly.Intersects(bbox)   ## << fails

[elpaso]

CC @rouault (a test will come)

[rouault]

shouldn't the proper fix be that constGeom.intersects( mFilterRect ) returns true when mFilterRect is degenerated to a point and contained in constGeom ?

[elpaso]

shouldn't the proper fix be that constGeom.intersects( mFilterRect ) returns true when mFilterRect is degenerated to a point and contained in constGeom ?

Do you mean to apply the fix deeper into in bool QgsGeometry::intersects( const QgsGeometry &geometry ) const ?

[elpaso]

... another candidate for the fix is QgsGeometry QgsGeometry::fromRect( const QgsRectangle &rect )

[rouault]

Do you mean to apply the fix deeper into in bool QgsGeometry::intersects( const QgsGeometry &geometry ) const ?

yes