Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split bugs #51797

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fix split bugs #51797

merged 2 commits into from
Feb 21, 2023

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Feb 10, 2023

Description

Fixes a couple of bugs introduced with the new split logic in #47306
Includes regression test for already fixed #49403

Fix #51501
Fix #50948

@uclaros uclaros added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Feb 10, 2023
@github-actions github-actions bot added this to the 3.30.0 milestone Feb 10, 2023
@rouault rouault added the backport queued_ltr_backports Queued Backports label Feb 10, 2023
@agiudiceandrea
Copy link
Contributor

@uclaros does this fix will also fix #51815?
@rouault don't you think this fix should be labelled with "backport release-3_28" instead of "backport queued_ltr_backports" as it allegedly fixes a crash?

@rouault
Copy link
Contributor

rouault commented Feb 11, 2023

@rouault don't you think this fix should be labelled with "backport release-3_28" instead of "backport queued_ltr_backports" as it allegedly fixes a crash?

ok, changed to 3.28 backport

@uclaros
Copy link
Contributor Author

uclaros commented Feb 12, 2023

@uclaros does this fix will also fix #51815?

@agiudiceandrea There's no data to actually test it, but judging from the provided stacktrace it should be fixed, it seems as a duplicate of one of the two addressed issues.

@agiudiceandrea
Copy link
Contributor

Layer provided in a subsequent comment: #51815 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption
Projects
None yet
4 participants