Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for geometry fields to memory provider #51846

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

nyalldawson
Copy link
Collaborator

Since the postgres provider supports these, the memory provider MUST also support them or we risk data loss

Temporarily includes #51842, #51844, #51845

@github-actions github-actions bot added this to the 3.30.0 milestone Feb 14, 2023
Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm a little concerned about if (and possibly how) store the CRS of the geometry. That piece of information is not available in plain geometry (referenced has it).

Did you consider that?

@nyalldawson
Copy link
Collaborator Author

LGTM, I'm a little concerned about if (and possibly how) store the CRS of the geometry. That piece of information is not available in plain geometry (referenced has it).

Did you consider that?

Well, the memory provider will accept referenced geometry values happily here. So we will gain support for eg reading values from postgres, storing in intermediate memory layers, and then writing back out to another postgres layer without any loss.

The issue comes in when features are edited and we force display of geometry values in a text widget. That situation isn't improved here. I still think that the correct approach there is a dedicated widget for geometry values in attribute forms, something like nyalldawson@3343750

Since the postgres provider supports these, the memory provider
MUST have support for them or we risk data loss
@nyalldawson nyalldawson merged commit 955c901 into qgis:master Feb 15, 2023
@nyalldawson nyalldawson deleted the memory_provider_geom branch February 15, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants