Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't open filter from indicator when layer is edited #51884

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

troopa81
Copy link
Contributor

Fixes #51816

@troopa81 troopa81 added GUI/UX Related to QGIS application GUI or User Experience Bug Either a bug report, or a bug fix. Let's hope for the latter! backport queued_ltr_backports Queued Backports labels Feb 15, 2023
@github-actions github-actions bot added this to the 3.30.0 milestone Feb 15, 2023
@uclaros
Copy link
Contributor

uclaros commented Feb 16, 2023

I know it's way more complicated than this, but how about opening the query builder but disallowing modifications?
This would allow the user to:

  • review the filter query of an editable layer in a more readable format than the tooltip.
  • check the list of available values for a field
  • save the filter to a file without stopping editing

@troopa81
Copy link
Contributor Author

Regarding your comment @uclaros , I have no strong opinion on whether it would be better or not. But for now, I prefer to stay consistent with the menu item and the properties source tab. It's beyond the scope of this PR.

@uclaros
Copy link
Contributor

uclaros commented Feb 16, 2023

In that case you should also close #44055, as the referenced issue is a recent duplicate

@troopa81
Copy link
Contributor Author

In that case you should also close #44055, as the referenced issue is a recent duplicate

Done, thanks for pointing that out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter dialog for vector layers in edit state can still be opened via the filter icon in the layers menu
3 participants