[Backport release-3_28] wmsgetcapabilities: Do not set a dimension default value if there are none #51933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WMS getCapabilities response tries to set a default value on multi-dimensional data. However, if the `values` list is empty, this can result in a segmentation fault because it can call `values.first()` or `values.last()` which is non valid for an empty list. This issue is fixed by checking if `values` list is empty before calling `values.first()` and `values.last()`. According to the WMS specification, the default parameter is optional. Therefore, in this case, the response is still valid.
nyalldawson
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #51930
Authored by: @ptitjano