[bugfix] Attribute table model not updated when a feature is changed. fixes #17280 #17187

[luipir]

Description

Backport of a 3.0 fix by @pblottiere. This would fix #17280 #17187

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

• Commit messages are descriptive and explain the rationale for changes
• Commits which fix bugs include fixes #11111 in the commit message next to the description
• Commits which add new features are tagged with [FEATURE] in the commit message
• Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
• I have read the QGIS Coding Standards and this PR complies with them
• This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
• New unit tests have been added for core changes
• I have run the scripts/prepare-commit.sh script before each commit

[luipir]

please @pblottiere you are the best to review this backport ;)

[pblottiere]

@luipir

I have just tested the patch and indeed it fixes an issue happening on the first row of the attribute table in 2.18 👍.

However, I'm not sure that this PR fully fixes the issue https://issues.qgis.org/issues/17187. In fact, the ticket has been opened 25 days ago and:

The issue also occurs in QGIS 2.99.0-Master.

However, the original PR is merged in master for a while now. So it seems that even with this patch, the issue #17187 is still happening on master. What do you think?

[luipir]

I'll check better 17187... in the meantime I removed it from the title and description

[luipir]

@pblottiere in the meantime we can merge this that for sure fix 17280. what do you think?

[gioman]

However, I'm not sure that this PR fully fixes the issue https://issues.qgis.org/issues/17187. In fact, the ticket has been opened 25 days ago and:

@pblottiere Hi, I tested the patch applying it to 2.18-dev code, and checked both #17187 and #17280, both seems fixed to me now.

[luipir]

@pblottiere may you merge? (I can't)

[pblottiere]

I tested the patch applying it to 2.18-dev code, and checked both #17187 and #17280, both seems fixed to me now.

Nice, good news :). Thank you for having tested this PR @gioman!

[pblottiere]

may you merge?

Done. Thank you for this patch @luipir!