Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Prevent a bad crash when provider is wrong #5552

Merged
merged 1 commit into from
Nov 7, 2017
Merged

[bugfix] Prevent a bad crash when provider is wrong #5552

merged 1 commit into from
Nov 7, 2017

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Nov 7, 2017

Fixes #17155

@nyalldawson
Copy link
Collaborator

@wonder-sk I believe you introduced this originally - can you comment?

@wonder-sk
Copy link
Member

Hehe indeed git blames me for those comments - but it was 10 years ago so I am not sure what the problem really was :-)

Using qobject_cast looks good to me - better than a static_cast or dynamic_cast

@elpaso
Copy link
Contributor Author

elpaso commented Nov 7, 2017

Let's say that we merge, ready to revert if windows starts crashing

@elpaso elpaso merged commit a22e565 into qgis:master Nov 7, 2017
@elpaso elpaso deleted the vector_layer_safe_cast branch November 7, 2017 10:56
@qgib qgib mentioned this pull request May 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elpaso @nyalldawson @wonder-sk