[gui] Datasource manager remove Ok and add Close

[elpaso]

Remove the "Ok" button (that was really an Add+Close: it added the layer and exited the dialog) in favour of "Close" button:

@rduivenvoorde , @nirvn , @SrNetoChan , @m-kuhn what's your feeling?

[nirvn]

@elpaso , thanks for giving this cool feature so much love. I'm -1 to remove the OK button, I actually love the add and ok button combination.

[elpaso]

See also: https://issues.qgis.org/issues/17292

[m-kuhn]

Thanks @elpaso, that will decrease the risk of unintentionally adding a layer multiple times.
Something else I think is important in terms of UX is some kind of feedback on the dialog itself, that the layers have been added.

[nyalldawson]

+1 for this change. I've tried to get used to the add/ok dynamics, but keep ending up with duplicate layers.

[SrNetoChan]

+1 for me. I prefer to waste the extra click on "Close" than having a much more complex GUI. Nyall Dawson <notifications@github.com> escreveu no dia segunda, 13/11/2017 às 19:24:

+1 for this change. I've tried to get used to the add/ok dynamics, but keep ending up with duplicate layers. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5616 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADcKeUIZm8llGlJWnP1NzKEVqzhDgBZFks5s2JdhgaJpZM4QbjdM> .

-- Alexandre Neto --------------------- @AlexNetoGeo http://sigsemgrilhetas.wordpress.com http://gisunchained.wordpress.com

[m-kuhn]

+1 for me. I prefer to waste the extra click on "Close" than having a much more complex GUI.

we could also just close the dialog upon clicking "Add" and ask people to use drag and drop or browser if they want to quickly add multiple layers at a time ;)

[nirvn]

I guess I was the only one liking it 😊

Any chance we could introduce a [x] close upon adding layer checkbox option to the left of the add button?

[nirvn]

@m-kuhn I'd indeed rather prefer for the Add button to close the dialog too, if we get rid of the Ok button.

[elpaso]

We could just resume the [x] don't close or [x] keep open checkbox, but that looks really wierd UI to me...

From the UX perspective, if you want to add and close, you can just click "Add" then on "Close" (it's just a few millimeters away, you don't have to move the pointer away too much. Or if you are a keyboard guy, just press ESC.

The fact is that in this dialog we have limited horizontal space in the button bar, most of full-width applications use a third button named something like Save and add another .... or in our scenario: Add and close

What I don't like in the Add - Ok - Close is that it's not immediately clear why Ok and Add should be different, that's why Add and close makes more sense to me, but this would probably take too much horizontal space.

It looks like we need to make some compromise here....

[m-kuhn]

We could just resume the [x] don't close or [x] keep open checkbox, but that looks really wierd UI to me...

Oh yeah, please don't resurrect this beast!

Do you dislike the Close and Add two-button solution where Add also closes the dialog?

[elpaso]

@m-kuhn I think that we want to keep the possibility to add multiple layers (from different providers) from the same dialog, so I believe that we need a way to keep it open.

[m-kuhn]

This happens almost never for me, but I'm happy to follow your lead on this

[elpaso]

@m-kuhn honestly I've not a strong opinion here, I'm just trying to collect the broadest consensus, that appears to be a "Mission Impossible"

If it was my decision I'd leave the python console as the only mean to add layers to the canvas ;)

Let's give this GUI a try and see ... now that there is a base class, it's really easy to change this behavior if we need to.

[m-kuhn]

Ok, sounds good.
That would be one of the places where I think it would be great to have some metrics sent back to us "how many users make another action between clicking Add and Close".

[elpaso]

@m-kuhn agreed.

Unfortunately, developers do not usually belong to the "typical users" set (provided that such a "typical user" really exists, because I've never met one).

Considering the whole GUI, a serious usability field study is what we really need here, and that would be an ideal job for a master thesis or some academic research, unless some deep pocketed company decide to finance such a study.

On the cheapest end: what do you think about a user survey?

Maybe @anitagraser or @rduivenvoorde have some good ideas too...

[anitagraser]

+1 for having an Add and a Close button instead of an OK button which does Add+Close. I agree that this is the more expected behavior and expected imho trumps saving a click.