Fix label mask sizes get reset to 0 #57555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This paper cut rears its head in that when first enabling label masks for an existing project layer, the mask size will default to "0", which is confusing for users as it seems to have no effect. The older maskSize attribute used to be treated as 0 instead of the default 1.5 mm size when no mask settings were available, and then when the project was saved this incorrect 0 value would become an actual valid attribute in the XML. Since we can't now differentiate a valid 0 value from an accidental 0 value in older projects, we instead assume "0" as a mistake and reset it to 1.5. when the project is saved the newer maskSize2 attribute will be used and we know that a "0" value WAS an explicit user choice.
nirvn
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paper cut rears its head in that when first enabling label masks for an existing project layer, the mask size will default to "0", which is confusing for users as it seems to have no effect.
The older maskSize attribute used to be treated as 0 instead of the default 1.5 mm size when no mask settings were available, and then when the project was saved this incorrect 0 value would become an actual valid attribute in the XML.
Since we can't now differentiate a valid 0 value from an accidental 0 value in older projects, we instead assume "0" as a mistake and reset it to 1.5. when the project is saved the newer maskSize2 attribute will be used and we know that a "0" value WAS an explicit user choice.