Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run sipify directly from PRs #58057

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Run sipify directly from PRs #58057

merged 1 commit into from
Jul 11, 2024

Conversation

3nids
Copy link
Member

@3nids 3nids commented Jul 10, 2024

By commenting /sipify on a PR, this workflow will automatically update the branch after running sipify_all

I've successfully tested this worklow on another repo, including on PRs from a fork, see 3nids#94

(this might be removed at a later stage by a pre-commit implementation)

By commenting /sipify on a PR, this workflow will automatically update the branch after running sipify_all
@github-actions github-actions bot added this to the 3.40.0 milestone Jul 10, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 843ff93)

@3nids 3nids changed the title Auto run sipify on PRs Run sipify directly on PRs Jul 10, 2024
@3nids 3nids changed the title Run sipify directly on PRs Run sipify directly from PRs Jul 10, 2024
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot!

Maybe we could also add an "astyle" one too? That'd help ease the pain for new contributors...

@lbartoletti
Copy link
Member

Let's give it a shot!

Maybe we could also add an "astyle" one too? That'd help ease the pain for new contributors...

+1 also help when patching directly from github

@3nids
Copy link
Member Author

3nids commented Jul 11, 2024

Maybe we could also add an "astyle" one too? That'd help ease the pain for new contributors...

Since this one applies on modified files only, it would be better suited for pre-commit and then we can easily add pre-commit.ci

@3nids 3nids merged commit 7c32a89 into master Jul 11, 2024
31 checks passed
@3nids 3nids deleted the 3nids-patch-1 branch July 11, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants