Contextmenu with individual actions #5961
Conversation
|
What's the empty entry at the top of the menu for? |
|
@nyalldawson It's an empty user defined action I used for tests and forgot to remove when I made the GIFS. Wasn't paying attention anymore on that myself. |
|
Ok, that makes sense :) wasn't sure if it was a design decision here |
src/app/qgsattributetabledialog.cpp
Outdated
| @@ -1042,6 +1043,21 @@ void QgsAttributeTableDialog::setFilterExpression( const QString &filterString, | |||
| } | |||
|
|
|||
|
|
|||
| void QgsAttributeTableDialog::deleteFeature( const QgsFeatureId &fid ) | |||
There was a problem hiding this comment.
The parameter should be passed by value QgsFeatureId fid, this is actually a simple long long which is faster to pass by value than by ref.
src/app/qgsattributetabledialog.cpp
Outdated
| mLayer->deleteFeature( fid ); | ||
| } | ||
|
|
||
| void QgsAttributeTableDialog::showContextMenu( QgsActionMenu *menu, const QgsFeatureId &fid ) |
src/gui/qgsrelationeditorwidget.cpp
Outdated
| { | ||
| QgsFeatureIds featureids; | ||
|
|
||
| if ( featureid ) |
There was a problem hiding this comment.
This looks dangerous, the featureid 0 is valid.
| void deleteFeatures( const QgsFeatureIds &featureids ); | ||
|
|
||
| /** | ||
| * Unlinks the features |
There was a problem hiding this comment.
"providing an empty list will use the current selection."
There was a problem hiding this comment.
I changed that. There are three methods now per function: duplicateSelectedFeatures (called by button), duplicateFeature (called by contextmenu), where duplicateFeature calls the duplicateFeatures with a list containing only one current feature and the duplicateSelectedFeatures with a list containing the selected features. It's not depending on the size of the FeatureIds if it's selected or not...
signedav
force-pushed
the
work_contextmenu
branch
2 times, most recently
from
4488327
to
ec3fa09
Compare
Individual actions in the contextmenu of the attributetable and the relationeditorwidget. It's unlink and delete feature in the relationeditorwidget. It's delete feature in the attributetable (form view)
signedav
force-pushed
the
work_contextmenu
branch
from
ec3fa09
to
2eaf4de
Compare
|
I'll see to it @nyalldawson |
|
PR for fix pending #6040 |
Individual actions in the contextmenu of the attributetable and the relationeditorwidget.
It's unlink feature and delete feature in the relationeditorwidget.
It's delete feature in the attributetable (form view)
Description
There are several action types like the maplayer actions and the user definded actions. These are actions that are specific for the GUI we are using. They do only appear there.
It's unlink and delete feature in the relationeditorwidget.
(here you can see the duplicate feature maplayer actions too)
It's delete feature in the attributetable (form view)
Unlike the maplayer actions these actions are not available when not in the edit mode. It can be discussed how it should be.