Update all attributes in a single transaction #6142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Jan 24, 2018
src/core/qgsvectorlayer.h
Outdated
| * | ||
| * \since QGIS 3.0 | ||
| */ | ||
| bool changeAttributeValues( QgsFeatureId fid, const QgsAttributeMap &newValues, const QgsAttributeMap &oldValues = QgsAttributeMap(), bool skeipDefaultValues = false ); |
src/core/qgsvectorlayer.h
Outdated
| * request to the underlying data provider, so it is more efficient to | ||
| * explicitly pass an oldValue if it is already available. | ||
| * | ||
| * If \a skipDefaultValue is set to true, default field values will not |
|
Oops, missed your test coming soon message :) |
|
@nyalldawson Thank you for your review! I updated the documentation and added some tests. Waiting for Travis now... |
|
I'll merge this PR tomorrow if I have no objections in the meantime. |
pblottiere
force-pushed
the
bugfix_transaction_constraints
branch
from
ce32247
to
e24b6bb
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update all attributes in one transaction in order to correctly check database constraints.
Fixes https://issues.qgis.org/issues/17869
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and containt sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit