[bugfix][wfs] Expand support for 2.0.0 TYPENAMES #6145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes qgis#17872 - WFS 2.0.0 DescribeFeatureType : TypeNames vs TypeName This PR introduces the plural form of TYPENAME for 2.0.0 WFS servers, with some additional logic to allow for 2.0.0 servers that only support TYPENAME for DescribeFeatureType: in this case, the singular form is also tried in case the plural one fails. There is still some work to do for transactional support but at least the read-only client part should now be ok. Tests have been added to check that: - TYPENAME form still works with old 2.0.0 - TYPENAMES form works with compliant 2.0.0 - choice geometry types are handled by calling GetFeature and examining the result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17872 - WFS 2.0.0 DescribeFeatureType : TypeNames vs TypeName
This PR introduces the plural form of TYPENAME for
2.0.0 WFS servers, with some additional logic to
allow for 2.0.0 servers that only support TYPENAME
for DescribeFeatureType: in this case, the singular
form is also tried in case the plural one fails.
There is still some work to do for transactional
support but at least the read-only client part
should now be ok.
Tests have been added to check that:
GetFeature and examining the result