Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves background color for search results in general option dialog #6420

Closed
wants to merge 1 commit into from
Closed

Improves background color for search results in general option dialog #6420

wants to merge 1 commit into from

Conversation

haubourg
Copy link
Member

fixes 18142 by a lighter yellow background and keeping a black font

Improves background color for search result in general option dialog
018cbce 
fixes 18142 by a lighter yellow background and keeping a black font
3nids
3nids reviewed Feb 22, 2018
View reviewed changes
Copy link
Member

@3nids 3nids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking it might be clearer to add some static variables here. Could you do it?

@haubourg
Copy link
Member Author

@3nids nah not yet, I have to learn C++ first :-)

@nyalldawson nyalldawson mentioned this pull request Mar 12, 2018
Merged
@nyalldawson
Copy link
Collaborator

@haubourg

In the interest of getting this merged I've made the requested change over at #6581

@haubourg
Copy link
Member Author

Nice!
Thanks for the C++ bootstrap course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3nids 3nids 3nids left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haubourg @nyalldawson @3nids