add flag to avoid UI prompt if a style already exists in the DB #6968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm.. current handling of this is pretty gross -- we really shouldn't be mixing the gui in here at all. What do you think about instead adding a "style exists" method, and then moving the messagebox up to app, and making saveStyleToDatabase always overwrite? |
|
I did it for postgresql provider. Spatialite and OGR look tedious ;-) |
|
New code looks good -- you'll just need to update the postgres provider tests to match (and add some tests for the new function) |
DelazJ
reviewed
May 22, 2018
| QgsDataSourceUri dsUri( mLayer->dataProvider()->uri() ); | ||
| if ( mLayer->styleExistsInDatabase( dsUri.table(), errorMsg ) ) | ||
| { | ||
| if ( QMessageBox::question( nullptr, QObject::tr( "Save style in database" ), |
There was a problem hiding this comment.
Title case for the messageBox dialog... There are few other places concerned.
nyalldawson
added
the
API
m-kuhn
added
the
Requires Tests!
|
I will come back on that in the next few weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a flag to avoid this window when you save styles in DB programmatically:
I think I'm not doing a API break like this. Is-it fine?
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit