[bugfix] Clear all DD props before creating symbol preview #7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes qgis#19096 - Applying a data defined size to a categorized layer hides its category symbol in the layers panel and legend
|
I think this is safe to do. At least, I can't see anywhere currently where symbolPreviewPixmap is called where the customContext is used AND an expression context is present. So the only regression here would be for properties which are based off expressions which don't rely on any feature attributes (like '1+2'). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19096 - Applying a data defined size to a categorized layer hides its category symbol in the layers panel and legend
@nyalldawson please have a look