Join cache refresh

[oliviercommelarbre]

Added join cache automatic update when the joined table is filtered/altered: A filter applied on the join destination (usually a DB table or a csv) now refreshes the join cache in the source layer(s) so that all join caches are systematically kept up to date and syncro with the joined database(s).
A global refresh action (e.g. triggered from the view menu) also triggers a refresh of all Join caches.

thanks for reviewing for merge into master

[mhugent]

assigned to @jef-n

[3nids]

this seems interesting, any feedback on this?

[3nids]

is this totally outdated?
@jef-n any chance to have a feedback on this?
@oliviercommelarbre would you be ok to rebase? sorry for not reviewing this in time.

[oliviercommelarbre]

Hi there, i could rebase with a bit of time (it was applicable on 1.9, july 2013), i'm interested myself to have the functionality in future versions .

I'm however a bit confused with the review mechanism, did i do anything wrong in the first place (i'm a newbie in github, it was my first contribution)?
can we ensure that a potential merge is then looked after / materialised within short time after the pull request is made (just to avoid that it gets outdated again)?
i will wait for your answer, thks

[3nids]

Hi Olivier,
You didn't do anything wrong, the problem is on our side. Time is sometime missing, and pulls are forgot -- which is not really acceptable.
Ideally, if you get an idea of who's the developer the most competent for this pull (otherwise, he will be assigned and you'll see this in the request), you can ask him by mail what's the status of the review.
Please commit your changes, and I hope this time the review will be faster.
Thanks for your comprehension.

[oliviercommelarbre]

OK thank you, i will find a bit of time to work on it.
I might need your help to get started again on the new master using GitHub. I was trying to fork the new master but for some reason, if i select that master and fork again, ( i.e. going to https://github.com/qgis/qgis, then activate the Fork button on that page), i'm left with my old fork of July 2013 (based on QGIS 1.8). It would be great if you could give me a quick help on how to update my git environment to work on the new master (knowing that my env is currently on my old fork of last year)?
great if you can get me started, then i'll do the rest

[3nids]

Hi,
First, on your local repo you need to add official's QGIS remote:
git remote add qgis https://github.com/qgis/QGIS.git
this will add a new "qgis" remote
then, fetch this remote:
git fetch qgis
then, you can rebase your branch on top of QGIS' master:
git checkout your_working_branch
git rebase qgis/master

I hope it's clear!

[oliviercommelarbre]

Thanks a lot Denis for this. all that worked and i could then get the master and apply my changes which i have then compiled and succesfully tested.
I might ask again for your support to submit on github.
My proposed changes are based on the 'master' branch of qgis/QGIS. Shall i just commit them on the server then create the associated pull request?

[3nids]

If you are still in the same branch (join-layer-refresh), you shall now pushit to the same remote branch that is used for this pull request.
You will have to force the push since you rebased you work:
git push -f origin join-layer-refresh if origin is the name of your personnal remote.
This is nice because the pull request will be automatically updated.

Otherwise you can push it to a new branch and create a new request.

[oliviercommelarbre]

Thanks again that was great help.
i had created locally the join-layer-refresh branch where all was committed then applied the git-push command as you indicated on the existing pull request. Sorry i've messed up the commit message without a proper title but all is there.
Is it now automatically going for review or i should trigger it?
thanks again!

[3nids]

Automatically is a big word ;)
The thing is that QGIS is in feature freeze before release of 2.4.
So, this won't be accepted before beginning of july.

@jef-n are you ok to review this?
or anyone else?

[3nids]

@wonder-sk could you have a look at this?

[wonder-sk]

I believe the refresh should be handled internally within the join buffer (where the cache is kept) and not to having to be triggered explicitly by API call. There may be other places setting subset string where the update would not happen. Moreover, there are various other events when the join cache may need to be invalidated - e.g. joined layer has change of attributes or added/removed features. I think those should be addressed too.

[m-kuhn]

@oliviercommelarbre What do you think about the comments by @wonder-sk ? Any chance to get ahead with this pull request?

[3nids]

@oliviercommelarbre any feedback?