Use ST_Force2D for PostGIS 2.1+ #777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
note: PostGIS-2.1.0 was just released so this wouldn't be bad to also have in the 2.0 branch of qgis... |
nyalldawson
added a commit
to nyalldawson/QGIS
that referenced
this pull request
Aug 1, 2016
All pointer based methods have been removed. Now we have only: void setGeometry( const QgsGeometry& geom ) and QgsGeometry geometry() const Benefits include avoiding a whole lot of tricky pointer lifetime issues, potential memory leaks, and finally closing qgis#777, which has survived for over 9 years!... Impacts on PyQGIS code: - no more need for the messy g = QgsGeometry( feature.geometry() ) workaround, just use g = feature.geometry() instead - IMPORTANT: you can no longer test whether a feature has geometry using `if f.geometry():`, since QgsFeature::geometry() will *always* return an object. Instead, use `if not f.geometry().isEmpty():`, or preferably the new method `if not f.hasGeometry():` Fix qgis#777
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid the WARNING about ST_Force_2D being deprecated when using PostGIS-2.1.0+.