Add more explicit error message when auxiliary storage is saved #8081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-kuhn
reviewed
Oct 1, 2018
| bool saveAs( const QString &filename ) const; | ||
| QString errorString() const; | ||
| %Docstring | ||
| Returns the underlying error string when something went wrong. |
There was a problem hiding this comment.
Would it be worth replacing "something went wrong" with something more explicit (and referencing to the saveAs method)?
There was a problem hiding this comment.
I updated the documentation accordingly. Let me know if you want me to modify something else or if it's not clear enough.
pblottiere
force-pushed
the
qgz_err_msgs
branch
from
f0c30a9
to
2f3fece
Compare
|
I'll merge this PR tomorrow if I don't have further remarks. |
|
Let's merge, looks good and gives more time for the verbose error messages to be collected to hopefully determine the underlying bug before 3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows the next issue: https://issues.qgis.org/issues/18477.
Actually, sometimes, auxiliary storage is not correctly saved, but I did not succeed in reproducing the error.
Considering that
QFile::remove()andQFile::copy()methods seems to be implicated, I propose to add a more explicit error message.Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit