[fix #17773] fix HiDPI in map canvas on mac #8242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For system introducing pixel device ratio, the image rendered by the canvas is actually scaled up to match the physical size of the canvas"
not sure how it works internally in Qt, but no need to call epxlicitely on scaling since the image device pixel ratio is set
|
Does this apply to layouts too? |
|
looks like this will have to be fixed too
|
This was referenced May 24, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So much time for such small changes!
This fixes the issue by integrating the device pixel ratio from Qt.
The images in renderer are scaled up to match the physical size of the canvas.
Many kudos to @wonder-sk for leading me in this black hole.
And to the sponsors of the Mac OS bugfixing!
left current, right fixed:
As a bonus, the scale was badly calculated before, and it's magically fixed :)
further reading: http://doc.qt.io/qt-5/scalability.html#high-dpi-scaling-on-macos-and-ios