Offline editing to GPKG attribute order. Fixes #20276 #8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because though fid appears to be the first field it's added in the end and has the last index. fixes qgis#20276
and use column++ again on iteration through attributes on copyVectorLayer fixes qgis#20276 especially the not reported issue with synchronization
luipir
changed the title
signedav
changed the title
signedav
changed the title
m-kuhn
changed the title
|
Backport? |
|
Yes. Will follow. |
This was referenced Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been messed up, because of the additional fid.
Is fixed now by:
Leaving last attribute empty instead of first on creating the GPKG layer features.
Handling fid attribute in attrLookup mapping on synchronization back.
It fixes #20276