Json expression functions #8887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Renamed the new aliases to be consistent with postgres: |
|
I can't remember for sure but I think I added json_to_map et cie during this development cycle. I don't mind seeing those aliases go away to keep only from_json / to_json. |
|
|
|
Wow, time passes by so fast. |
|
Assigned to @nirvn as the author of the function ;P |
|
@m-kuhn , all good stuff, merged 😄 |
|
Thanks @nirvn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current JSON expression functions only work with maps. There is no reason for that.
This PR adjusts the current functions so they also work with arrays, raw string values and whatever QJson may support.
There are also 2 aliases
json_to_mapis now also available asfrom_jsonandmap_to_jsonis now also available asto_json.I'm not a huge fan of the names, suggestions welcome.