Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide orange measure line and points while measure tool is inactive #9421

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

raymondnijssen
Copy link
Contributor

Description

When selecting another tool while using the measure tool, the measure dialog disappeares but the orange rubberband lines and points stayed visible. They could only be removed by reselecting the measure tool and close the dialog, being confusing to the user.

This new code makes the rubberband hidden while not using the measure tool and shows it when reselecting the tool.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • [v] Commit messages are descriptive and explain the rationale for changes
  • [-] Commits which fix bugs include fixes #11111 in the commit message next to the description
  • [-] Commits which add new features are tagged with [FEATURE] in the commit message
  • [-] Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • [v] I have read the QGIS Coding Standards and this PR complies with them
  • [v] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • [-] New unit tests have been added for core changes
  • [v] I have run the scripts/prepare-commit.sh script before each commit

@m-kuhn m-kuhn merged commit 99cedd6 into qgis:master Mar 8, 2019
@m-kuhn
Copy link
Member

m-kuhn commented Mar 8, 2019

Should this be backported?

@raymondnijssen
Copy link
Contributor Author

@m-kuhn Would be nice to backport it :)

@backporting
Copy link
Contributor

backporting bot commented Mar 8, 2019

The backport to release-3_4 failed:

Reference already exists

m-kuhn added a commit that referenced this pull request Mar 8, 2019
m-kuhn added a commit that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants