Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re)add the alpha option for the GDAL color relief tool #9442

Closed

Conversation

gioman
Copy link
Contributor

@gioman gioman commented Mar 9, 2019

Description

This option was not ported when we got rid of the old GDAL tools core plugin.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • Did not drink while coding

@gioman
Copy link
Contributor Author

gioman commented Mar 9, 2019

@luipir Luigi will show me about adding tests today ;)

@nyalldawson
Copy link
Collaborator

+1, and +2 if you add tests 😉

@gioman
Copy link
Contributor Author

gioman commented Mar 11, 2019

+1, and +2 if you add tests

@nyalldawson yes, now I have no more excuses

@stale
Copy link

stale bot commented Mar 25, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 25, 2019
@luipir
Copy link
Contributor

luipir commented Mar 25, 2019

+1, and +2 if you add tests

I should say sorry to @gioman I wasn't able to help him during hackmeeting... I was able to open the laptop only at 7PM every day of the meeting!

@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 25, 2019
@nyalldawson
Copy link
Collaborator

So what's the way forward here?

@nyalldawson nyalldawson added this to the 3.8 milestone Mar 31, 2019
@stale
Copy link

stale bot commented Apr 14, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 14, 2019
@stale
Copy link

stale bot commented Apr 21, 2019

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@stale stale bot closed this Apr 21, 2019
@luipir
Copy link
Contributor

luipir commented Apr 22, 2019

came on @gioman do these tests! (pressure pressure pressure ;) )

@luipir luipir reopened this Apr 22, 2019
@stale stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 22, 2019
@stale
Copy link

stale bot commented May 6, 2019

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@stale stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 6, 2019
@stale
Copy link

stale bot commented May 13, 2019

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants