Show a raw version of the feeds #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks ! LGTM |
|
You're welcome. |
dimasciput
requested changes
Jan 3, 2024
qgisfeedproject/qgisfeed/views.py
Outdated
| else: | ||
| args = { | ||
| "data": data, | ||
| "form": form | ||
| "form": form, | ||
| "data_json": data_json |
There was a problem hiding this comment.
@Xpirix, shouldn't we use indented JSON data here for non-debug purposes, since it will be displayed on the frontend?
There was a problem hiding this comment.
@dimasciput You're right. I've made the change.
dimasciput
approved these changes
Jan 4, 2024
|
This PR has been deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the result of the request on the root URL depends on the agent, i.e it returns a raw json if the request is made from qgis and a web page if it's from a browser.
This PR proposes to show both the preview and the raw json on the home web page.
Changes summary
highlight.jsPreviewfor the feeds preview andRawfor the feeds JSON raw viewRequirement
Please find below a screenshot of the raw view on the home page:
