Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Django 4 to fix OL map #61

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Dec 19, 2023

I suspected mismatched Django versions between my local and the production environment. I noticed that the OpenLayers map in the Set spatial filter modal doesn't show when using Django 3. I've tried the current and the last patched version (3.2.11 and 3.2.23). It works fine after upgrading to Django 4.2.8.

Changes summary:

  • Upgrade to Django 4, and update some dependencies in the requirements.

Requirement:

  • These changes require a build on the server side.

Please find below the screenshot of the Set spatial filter modal when using Django 4:

image

@Xpirix Xpirix marked this pull request as draft December 19, 2023 11:04
@Xpirix Xpirix marked this pull request as ready for review December 19, 2023 11:57
@haubourg
Copy link
Member

Cool thanks!
In the long run a dockerised dev environment can help to have the same env as the server has.

Go for merge !

@Xpirix
Copy link
Collaborator Author

Xpirix commented Dec 19, 2023

My pleasure.

You're right, having a dockerized development environment helps mirror the server environment and is easy to run. Thanks for the tip.

@dimasciput dimasciput merged commit c53db91 into qgis:master Jan 3, 2024
2 checks passed
@Xpirix Xpirix deleted the fix_spatial_filter_map branch January 3, 2024 07:29
@Xpirix
Copy link
Collaborator Author

Xpirix commented Jan 30, 2024

Upgrading to Django 4 involves upgrading other stacks on the server side (PostGIS, docker engine...) and may cause downtime so we need to plan it correctly. For now, I will try another method to fix the map in the spatial filter window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants